Martin Panter added the comment: My point about Python 2 was that this might add an annoying difference between the two branches. Even if you don’t apply this to Py 2, the next person adding or updating a test might be inclined to do it.
Looking closer at your patch I admit that addCleanup() wouldn’t be appropriate except for the first change. Maybe it would be okay to leave the “try / finally” cases as they are? Moving connect() inside is good though IMO. Anyway, I’m only mildly against this. I don’t see much benefit, but I could tolerate the downsides. I guess it’s up to you. ---------- components: +Tests stage: -> patch review _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue26612> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
