Martin Panter added the comment: There are some spelling errors in the comments. It would also be good to keep the indentation, quoting, layout etc similar to the surrounding code.
Regarding the comments, what is the significance of “runtime platform” vs MACHDEP? Also, what is the significance of sys.platform() when setting _PYTHON_HOST_PLATFORM? Why did you use different types of comments? (# vs dnl) I do not understand the comment “build must not depend from posix-compatible environment”. Is this just explaining that we are setting ac_sys_system (uname -s) to a dummy generic value that will not trigger any special cases. Should we also set ac_sys_release to an empty string, like the cross-compiling case later on? What’s the go with the two competing “mingw*)” cases when determining _PYTHON_HOST_PLATFORM? What is the situation where $host matches *-*-mingw*, but $host_os does not match mingw*? ---------- nosy: +martin.panter stage: -> patch review _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue17592> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
