New submission from Martin Panter:

This small patch cleans up two oddities calling run_gdb() in 
/Lib/test/test_gdb.py that I noticed. They were both added in revision 
b71cda2f48c6. The first one is a whole GDB command being passed to GDB as extra 
arguments. Notice “gdb --batch -nx” is in the argument tuple twice:

test_NULL_ob_type (test.test_gdb.PrettyPrintTests)
Ensure that a PyObject* with NULL ob_type is handled gracefully ... ('gdb', 
'--batch', '-nx', '-iex', 'add-auto-load-safe-path 
/media/disk/home/proj/python/cpython/python-gdb.py', 'gdb', '--batch', '-nx', 
'--eval-command=set breakpoint pending yes', '--eval-command=break builtin_id', 
'--eval-command=set print address off', '--eval-command=run', 
'--eval-command=set print entry-values no', '--eval-command=set v->ob_type=0', 
'--eval-command=backtrace', '--args', 
'/media/disk/home/proj/python/cpython/python', '-S', '-c', 'id(42)')
ok

The other is just an assignment that was never used.

----------
components: Tests
files: gdb-cleanup.patch
keywords: patch
messages: 256092
nosy: martin.panter, r.david.murray
priority: normal
severity: normal
stage: patch review
status: open
title: Clean up run_gdb() calls
type: enhancement
versions: Python 2.7, Python 3.5, Python 3.6
Added file: http://bugs.python.org/file41266/gdb-cleanup.patch

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue25820>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to