Martin Panter added the comment:

I suggest changing the “except” clause to “except BaseException”, which would 
make the intention clearer.

As an alternative, see also my Issue 23430, were I proposed not catching 
exceptions like KeyboardInterrupt and SystemExit, by changing this to:

try:
    self.finish_request(request, client_address)
except Exception:
    self.handle_error(request, client_address)
finally:
    self.shutdown_request(request)

----------
nosy: +martin.panter
title: Just a little refactoring -> socketserver.ThreadingMixIn exception 
handler: Just a little refactoring

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue25139>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to