Nick Coghlan added the comment: Huh, for some reason the Rietveld diff missed the changes to _testmultiphase.c that are in the patch file.
The change looks good to me. The test adds a new "test.imp_dummy" module, imports that, and then ensures it can be replaced by using imp.load_dynamic to import "test.imp_dummy" from the _testmultiphase module instead. The functional change itself is isolated to imp.load_dynamic, so no other code paths will be affected. ---------- stage: test needed -> commit review _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue24748> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
