Robert Collins added the comment:

We can't use from_exception in __init__ because from_exception's job is to look 
up __traceback__, but the legacy API allows arbitrary tb objects which may not 
be exc.__traceback__, and modifying exc.__traceback__ or creating a shim object 
just to be able to use from_exception doesn't make sense to me.

This patch looks good, and I'm applying to 3.6. It has no functional impact 
(except for perhaps weird mocking corner cases, but as its a pure class that 
shouldn't be needed), so I'm leaving it out of 3.5, since i'm not 100% sure 
where the move to a new repo is at, and its not worth figuring that out.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue24710>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to