Jacek Kołodziej added the comment: I'm getting patches ready with amendments you've proposed. Two things, though (and two on Rietveld):
> That raiseExecptions thing looks like a typo to me. The code should probably > be monkey patching the module variable, and restoring it after the test. Then > you wouldn’t need to add your extra typoed version to the blacklist. Wouldn't it be better to just blacklist the typoed version in this patch, with proper comment, and then fix the typo along with test? Working it around like you proposed looks like unnecessary overkill. I'm also not yet sure where is the "don't change too much in one patch" border. > pickletools.OpcodeInfo: It is briefly mentioned as the type of the first item > of genops(). I don’t have a strong opinion, but I tended to agree with your > previous patch which added it to __all__. That addition was a little absentminded of me, sorry for that. Is such brief mention considered a documentation for a part of API in this case? ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23883> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
