STINNER Victor added the comment:
polar_errno.patch doesn't apply cleanly on the default branch, I get that you
wrote your patch for Python 3.4.
+ @cpython_only
+ def test_polar_errno(self):
+ # Check a previously set C errno doesn't disturb polar()
Please add the number of this issue in the comment.
+ inf = float('inf')
+ ...
+ nan = float('nan')
On Python 3.5 and 3.6, You can use math.inf and math.nan.
Except of that, the patch looks good to me.
----------
nosy: +haypo
_______________________________________
Python tracker <[email protected]>
<http://bugs.python.org/issue24489>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
