Amaury Forgeot d'Arc <[EMAIL PROTECTED]> added the comment:

about range_eq7.patch:

- Did you change your mind about range equality?
  range(0,10,2) == range(0,9,2)
seems True now; it was not with range_eq6.patch

- The hash function will fail with big values (and wrongly returns a
value even when an exception is set). I suggest to call PyObject_Hash
instead of PyNumber_AsSsize_t.

- Now that you short-circuit the comparison, it is enough to have only
one boolean variable (is_equal), which may replace all uses of
start_same, stop_same and step_same.

__________________________________
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2603>
__________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to