Alexander Belopolsky <[EMAIL PROTECTED]> added the comment: On the interface, I would suggest renaming 'exclude' to 'ignore' for consistency with filecmp.dircmp. Also consider detecting file separator in the patterns and interpreting them as an absolute (if pattern.startswith(pathsep)) or relative with respect to src.
On the implementation, consider making 'exclude_files' a set for a faster lookup. It should also be possible to refactor the code to avoid checking the type of 'exclude' on every file and every recursion. ---------- nosy: +belopolsky __________________________________ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2663> __________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
