Berker Peksag added the comment: Looks good. Two things:
* I'd apply this only to the default branch. Changing exceptions from AssertionError to ValueError in bugfix releases may break third party code. I couldn't find a similar bug report in the tracker, so it's probably not worth to take that risk. * We should audit the standard library for similar issues ---------- assignee: -> serhiy.storchaka nosy: +berker.peksag stage: patch review -> commit review _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23776> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com