Berker Peksag added the comment: Looks good. A couple of comments:
* Doc/includes/email-* changes have already been committed. * There is a commented-out line in Tools/scripts/nm2def.py: - f.close() + # f.close() * The patch is huge, I'd commit Tools/ and Lib/test/ parts separately. * Most of the open(..., 'r') usages can be changed to open(...) * It would be good to add context management protocol support to http.client.HTTPConnection. ---------- nosy: +berker.peksag _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue22831> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
