Raymond Hettinger added the comment: Thanks Mark. I appreciate the effort looking at use cases.
I'm reopening this one because I have an alternative patch that simplifies the code but keeps the unicode specialization. It replaces the lookkey indirection with a fast and predictable inline test for PyUnicode_CheckExact. The timings show no measureable difference, but the code is simpler and the setobject size is reduced by one pointer. This simplify future maintenance and development as well as making the code more pleasant. ---------- resolution: rejected -> stage: -> patch review status: closed -> open Added file: http://bugs.python.org/file37848/inline_unicode_specialization.diff _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue23119> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
