Serhiy Storchaka added the comment: Thank you Raymond for the review.
> I especially like the removal of superfluous OPCODES dictionary lookups The disadvantage is that now backporting patches to old branches is harder. > Since the op codes are singletons, you can use identity tests instead of > equality checks in sre_parse.py: This is deliberate. There is small change that the opcodes could became an integers in future (after adding introspection to pattern object, or make it copyable, or allowing serialization of compiled codes). "is" instead of "==" can cause subtle bug. Note that "is" is used during parsing, but getwidth() is called from sre_compile.py. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue22434> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
