Marc-Andre Lemburg added the comment: On 15.09.2014 15:19, STINNER Victor wrote: > > STINNER Victor added the comment: > > IMO test_codecs_fix1.patch is still needed. > > Review of Nick's change: > > + interp = PyThreadState_GET()->interp; > + if (interp->codec_search_path == NULL) { > + return -1; > + } > > I don't think that this line raises an exception.
Agreed. Please also add some documentation to the codecs.h file and perhaps a test for the function itself ;-) ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue22166> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com