Charles-François Natali added the comment:

> It doesn't answer to my complain: I don't want to support file descriptors on 
> Windows anymore because file descriptors cannot be configured in non-blocking 
> mode.

I think it does : if an exception is raised if an FD/handler is not in
non-blocking mode, this should include Windows file descriptors,
right?

> If we raise an error if FD and sockets are blocking, calling set_wakeup_fd() 
> on a FD on Windows would always fail. So raising an exception because the 
> integer is a file descriptor or raising an exception because the file 
> descriptor is blocking leads to same result: FD are not more supported on 
> Windows.

See above, I'm not sure what you're complaining about: since file
descriptors can't be made non-blocking on Windows, trying to register
them will raise an error. And since there's another issue for this, I
don't think the check belong in this patch (although it would proably
make more sense to commit the other patch first).

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue22018>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to