Raymond Hettinger added the comment:

The looks good.  Please revise the patch to isolate the actual change in logic 
and not confound it with PEP-8 nits which make the patch harder to review.

Also, please be careful with breaking lines.  In the following part of the 
diff, the space after "matrix:" is lost (Hazards like this are one reason to 
avoid cosmetic changes).

-            raise TurtleGraphicsError("Bad shape transform matrix: must not be 
singular")
+            raise TurtleGraphicsError(("Bad shape transform matrix:"
+                                       "must not be singular")

----------
assignee:  -> rhettinger
nosy: +rhettinger

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue21812>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to