Tal Einat added the comment: I've done a thorough review of the tests. The overall structure and tests are fine, but I found quite a few issues that should be addressed.
Saimadhav, considering these are some of the first tests you've written, please know that I am impressed! I have many comments because I believe our tests should be excellent and I'm a bit pedantic. However I've seen many people write poorer test suites after despite having considerable experience. So keep up the good work, learn from our feedback and everything will be great! ---------- nosy: +taleinat _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue21696> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
