Benjamin Peterson added the comment: On Tue, Apr 15, 2014, at 2:34, Dima Tisnek wrote: > > Dima Tisnek added the comment: > > Banjamin, Your patch looks good to me! > > I have a small concern regarding "We now know we will succeed..." -- > should there be a test case to make sure fstat test here matches whatever > test is/was done on a lower level? > > Or is your code now such that it will explicitly succeed because it > doesn't call anything that can fail after the comment?
That's what I mean. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue21191> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
