A.M. Kuchling added the comment:

Random notes on bugday.distutils.patch:

* dist.py: this change should definitely be applied, no matter what 
  happens to the rest of the patch.

* Yay!  Lots of tests!

* distutils.pypirc: I'm doubtful of the finalize_options() here;
  looking for '-r' in the args seems like it could get confused 
  if there are packages or other arguments that just happen
  to use that name.  It seems like a remote possibility, but still...

* distutils.pypirc: Class name typo in module docstring.
  
* Would the distutils.pypirc module be better named something like
  distutils.config?

* register.py: why use PyPIRCCommand.DEFAULT_REPOSITORY 
  and not register.DEFAULT_REPOSITORY?  I guess it's more useful to
  have a single Distutil-wide default repository.  No action needed.

----------
nosy: +akuchling

__________________________________
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1858>
__________________________________
_______________________________________________
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to