Antoine Pitrou added the comment: About the patch (note the code review tool hasn't accepted it, so I'm commenting here): - in the tests, I think comparing stderr as-is will fail under Windows, where the line separator is b"\r\n"; better call splitlines() first - in the tests, I think it would be better to use test.script_helper.assert_python_ok() (it will automate some stuff for you), even though other tests don't in that file - in main.c, you need to Py_DECREF warning_options when you are done with it.
---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue20355> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
