Antoine Pitrou added the comment: Some things: - the concept of a nullable thing in Python doesn't exist; why not "optional"? - why is there a "error" field in the new structs? - the fact that the structs are defined in longobject.h looks bonkers - boolean fields can be "char" instead of "int" (and moved at the end to pack the structure more efficiently) - PyLong_AsSsize_t can't fail? - does this change have a performance impact?
---------- nosy: +pitrou _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue20341> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com