Vajrasky Kok added the comment: Here is the patch addressing some of Serhiys concerns. Thanks for the review.
There are some things that I could not make it up: 1. The test for unencodable tarinfo.linkname is not done yet, because maybe it is better to be done in a separate ticket. To make the test simple, we need to modify the testtar.tar file. We need to add file with unencodable linkname. Is it too much to do it in this ticket? 2. "should exist separate test (not in CommandLineTest) for the TarFile.list() method itself." -> I haven't got the inspiration yet how to create this test to add additional value. ---------- Added file: http://bugs.python.org/file33608/fix_tarfile_list_print_lone_surrogate_v3.patch _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue19920> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
