PJ Eby added the comment: The new patch will have weird results in the case of a parent module that defines an attribute that's later replaced by an import, e.g. if foo/__init__.py defines a variable 'bar' that's a proxy for the foo.bar module. This is especially problematic if this proxy is used during the process of importing foo.bar
At the very least, this code should NOT be deleting the original foo.bar attribute, but rather restoring its previous value. All in all, I don't think this is a productive route to take. It was discussed on Python-dev previously and IIRC I outlined all the other reasons why back then. The approach in issue17636 is the only one that doesn't change the semantics of any existing, not-currently-broken code. In contrast, the proposed change here introduces new side-effects and *more* volatile state and temporal coupling. I don't think this should go in, since the other approach *only* affects execution paths that would currently raise ImportError. ---------- nosy: +pje _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue992389> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
