[issue1926] NNTPS support in nntplib

[Bill Janssen]

Bill Janssen added the comment:

Great, Ray.

I don't see any test cases for the nntp library in the Lib/test/ directory.
How can we make sure it works on the buildbots?

Bill

On Jan 25, 2008 12:49 PM, Ray Chason <[EMAIL PROTECTED]> wrote:

>
> Ray Chason added the comment:
>
> Here's take 2.
>
> The pre-patch NNTP class has a long and complicated constructor.  Rather
> than duplicate this constructor in NNTP_SSL, the patch converts most of
> the NNTP class to a new class, NNTPBase, which takes an
> already-connected socket as a parameter.  NNTP and NNTP_SSL both inherit
> NNTPBase and create that socket in their own respective ways.
>
> Added file: http://bugs.python.org/file9286/python-nntps-patch-2.txt
>
> __________________________________
> Tracker <[EMAIL PROTECTED]>
> <http://bugs.python.org/issue1926>
> __________________________________
>

Added file: http://bugs.python.org/file9298/unnamed

__________________________________
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1926>
__________________________________
Great, Ray.<br><br>I don&#39;t see any test cases for the nntp library in the 
Lib/test/ directory.&nbsp; How can we make sure it works on the 
buildbots?<br><br>Bill<br><br><div class="gmail_quote">On Jan 25, 2008 12:49 
PM, Ray Chason &lt;<a href="mailto:[EMAIL PROTECTED]">[EMAIL PROTECTED]</a>&gt; 
wrote:<br>
<blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 
204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><div 
class="Ih2E3d"><br>Ray Chason added the comment:<br><br></div>Here&#39;s take 
2.<br><br>
The pre-patch NNTP class has a long and complicated constructor. 
&nbsp;Rather<br>than duplicate this constructor in NNTP_SSL, the patch converts 
most of<br>the NNTP class to a new class, NNTPBase, which takes 
an<br>already-connected socket as a parameter. &nbsp;NNTP and NNTP_SSL both 
inherit<br>
NNTPBase and create that socket in their own respective ways.<br><br>Added 
file: <a href="http://bugs.python.org/file9286/python-nntps-patch-2.txt"; 
target="_blank">http://bugs.python.org/file9286/python-nntps-patch-2.txt</a><br>
<div><div></div><div 
class="Wj3C7c"><br>__________________________________<br>Tracker &lt;<a 
href="mailto:[EMAIL PROTECTED]">[EMAIL PROTECTED]</a>&gt;<br>&lt;<a 
href="http://bugs.python.org/issue1926"; 
target="_blank">http://bugs.python.org/issue1926</a>&gt;<br>
__________________________________<br></div></div></blockquote></div><br>


_______________________________________________
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com