Ezio Melotti added the comment: The assertions have their arguments in the wrong order, it should be (actual, expected). In the code of the module there are also some examples in the comments, e.g.: # path is something like ////host/path/on/remote/host # convert this to \\host\path\on\remote\host Even though the path is covered, there's no similar test in this patch. I would suggest you to include all the examples from the module in the tests.
Also note that this module is already indirectly tested in test_urllib. ---------- nosy: +ezio.melotti stage: -> patch review type: -> enhancement _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue19383> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
