Phillip J. Eby added the comment:

On systems where the gzip or bz2 modules aren't installed, this patch
can raise a tarfile.CompressionError, which should be caught and handled
correctly.  The import of tarfile should also be inside the relevant
function (as is done for make_zipfile) instead of at the top level.

Other than those two points, the patch looks great.

----------
nosy: +pje

__________________________________
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1886>
__________________________________
_______________________________________________
Python-bugs-list mailing list 
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to