Ezio Melotti added the comment: I left a review on rietveld.
FWIW I think string_tests and related files should undergo a (major?) refactoring. I worked with them a few times and it's a bit of a mess with all those base classes and mixins. I also found some tests that weren't running because they were accidentally overridden by one of the subclasses, or other tests that were duplicated. This is especially true on Python 3, where bytes and str share a smaller subset of features. ---------- nosy: +ezio.melotti stage: -> patch review type: -> enhancement versions: +Python 3.4 -Python 3.2 _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue14019> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com