Alexander Belopolsky added the comment: According to this comment, ssb.values can be null:
/* A sortslice contains a pointer to an array of keys and a pointer to * an array of corresponding values. In other words, keys[i] * corresponds with values[i]. If values == NULL, then the keys are * also the values. * * Several convenience routines are provided here, so that keys and * values are always moved in sync. */ <http://hg.python.org/cpython/file/tip/Objects/listobject.c#l969> However, is ssb.values is null, dest.values must be null as well and sortslice_copy_decr() will not dereference either of the pointers. Looks like a false positive to me, but I wonder if a strategically placed assert will silence coverity: Py_LOCAL_INLINE(void) sortslice_copy_decr(sortslice *dst, sortslice *src) { *dst->keys-- = *src->keys--; if (dst->values != NULL) { assert(src->values != NULL); *dst->values-- = *src->values--; } } ---------- nosy: +belopolsky _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue18579> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
