Christian Heimes added the comment:

I don't think that a reordered idx < 0 check is going to make any measurable 
difference. I like the separate checks as they make the code easier to 
understand. The first check tests for error in PyLong_AsSsize_t() and the 
second one checks for positive integers.

----------
stage: commit review -> committed/rejected
status: open -> closed

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue18339>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to