Martin Morrison added the comment: On 21 Apr 2013, at 17:38, Serhiy Storchaka <rep...@bugs.python.org> wrote: > Serhiy Storchaka added the comment: > > As for interface, I think 'adobe' flag should be false by default. It makes > encoder simpler. ascii85 encoder in Go's standard library doesn't wrap nor > add Adobe's brackets. btoa/atob functions looks redundant as we can just use > a85encode/a85decoder with appropriate options. Perhaps we should get rid from > 'adobe' flag in a85decode and autodetect it. And perhaps to do the same with > other a85decode's options.
The problem with autodetecting is that it makes it impossible for an application to use this library to verify that something is encoded in a specific way. Explicit is better than implicit. Otherwise, your changes look good to me. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue17618> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
