Antoine Pitrou added the comment:

The Mercurial authors have given their informal agreement for a relicensing. 
OTOH, they must still sign a contributor's agreement. The relicensing would 
allow us to use their pure Python implementation (in mercurial/pure/base85.py). 
OTOH, the C implementation (in mercurial/base85.c) is a ripoff of the git one, 
so we'd better rewrite our own.

My current plan would be the following:
- create a binascii.py and rename binascii.c to _binascii.c
- add Mercurial's pure Python implementation to binascii.py
- add a custom C implementation to _binascii.c
- make sure the binascii test suite tests both implementations

OTOH, if we don't get the Mercurial authors' contributor agreement, we can also 
re-write our own pure Python implementation.

In any case, our implementation should IMHO be compatible with Mercurial's 
(i.e. produce identical outputs for the same inputs).

----------
stage:  -> needs patch

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue17618>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to