R. David Murray added the comment: Aman: another nit: PEP8 calls for no unneeded parentheses around logical expressions, so things like:
if(self.f): should be written: if self.f: in order to adhere to our coding style. Also, it's not obvious to me that there is any reason to rename the base classes (PicklerTests->AbstractIOPicklerTests, and same for Persistent test). Finally, rereading Serhiy's note, Python3 only has "general IO streams", both non-IO files and cStringIO.StringIO are gone. So this really is a 2.7-only issue, and only worth doing because 2.7 is a long term maintenance release. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue17299> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
