Stefan Krah added the comment: Serhiy Storchaka <rep...@bugs.python.org> wrote: > > It seems like it would make more sense to combine both checks into one > > decorator. > > These are different cases. @unittest.skipIf(sys.flags.optimize >= 2) is about > docstrings in Python implemented modules, and @support.requires_docstrings is > about docstrings in C implemented modules.
But they're always used together, aren't they? I kind of like the idea of a single decorator. We could have two different messages "compiled without docstrings" and "docstrings are omitted with -O2 and above", where the first message should get priority if both conditions are true. Given the mood on python-dev concerning --without-doc-strings, I wonder if we should stick to minimal changes and just skip the tests in test_pydoc.py instead of fixing them. Personally I'm happy either way. David, what do you think? ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue17041> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com