Georg Brandl added the comment:

A few comments:

* If the issue with patch is closed as duplicate, the patch should be attached 
to the superseder.

* The patch looks awfully long for such a simple option list. (e.g., 
get_version() is just lambda x: x[:3], no need for a function to do that.)

* Keep in mind that you can't easily support 2.5 and down anyway, since their 
URLs are completely different.  I call YAGNI on including anything older than 
2.6.

* Please make it configurable, as indicated. You can add an option recognized 
by Sphinx in Doc/tools/sphinxext/pyspecific.py, with app.add_config_value.  I 
will then set it properly in the script that rebuilds the docs on 
docs.python.org.

That said, the result looks nice.  If we can work out the specifics, +1 for 
something like it.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue8040>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to