Antoine Pitrou added the comment: > > the coding style there is quite old > > It would be great if you could elaborate, however briefly, if there's > anything else besides your fixes that is old and should be modernized. > I will admit to writing some of that code very recently, but that's > mostly because I was trying to follow the existing coding style of the > module, which was written a long time ago.
I don't think that's you. I was talking about some of the cruft I removed (such as list_join() which was going through complicated hoops instead of calling PyUnicode_Join(), or manual filling of tuples instead of calling PyTuple_Pack()). There are still issues with internal functions stealing references and such. ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue16089> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
