New submission from Amaury Forgeot d'Arc: This patch corrects a problem in test_file.py on Windows: f.truncate() seeks to the truncation point, but does not empty the buffers. In the test, f.tell() returns -1...
Now we flush the file before, and seek to the initial position after. The same trick was present in 2.5, in fileobject.c::file_truncate. The same comments apply as well. Reviewers needed! Flushing may change the behaviour, but seems more correct to me (and closer to python2.5). Should we add specific tests for this? Also, change the test to be sure to close the file before trying to remove it (it seems that in a finally: block, the exception still references all the local variables in the traceback). Otherwise the previous problem is hidden by a "file locked" error in the finally block. ---------- components: Windows files: truncate.diff messages: 56732 nosy: amaury.forgeotdarc severity: normal status: open title: py3k: file.truncate() changes the file position versions: Python 3.0 Added file: http://bugs.python.org/file8606/truncate.diff __________________________________ Tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue1323> __________________________________
truncate.diff
Description: Binary data
_______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
