Christian Heimes <li...@cheimes.de> added the comment:

I've two suggestions:

* rename the function to 'total_compare'. The name explains what the function 
actually does in comparison to '=='. It takes the total input values into 
account instead of using short circuit comparison.

* restrict the function to bytes. The implementation works well with bytes but 
not with unicode. It's not an issue since hash digests are bytes. The docs 
could explain the issue with unicode and how user code can implement a 
reasonable safe conversion.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue15061>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to