Antoine Pitrou <pit...@free.fr> added the comment:
Given than there is no native "half float" in C (AFAIK), does it make sense to
have a native variant of half floats?
Also:
+ {'e', sizeof(short), SHORT_ALIGN, nu_halffloat, np_halffloat},
Shouldn't it be 2 rather than sizeof(short)? And why SHORT_ALIGN?
Other comments:
- in the tests, please remove the commented out print() calls
- in the tests, I don't understand why some examples are commented out; you
should explain why (add a comment)
- you can add the "import math" at the top-level, rather than in the test method
- in the doc, you need a "versionchanged" or "versionadded" tag to specify that
half-float support was added in 3.3
I'll let others review the numerical code, if necessary.
----------
_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue11734>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
