STINNER Victor <victor.stin...@gmail.com> added the comment:

The patch looks good to me. I was going to commit it but then I realized that 
Larry is a core developer. Last nits: you should add a newline after } in "} 
else {", and it would be better to move billion variable into fill_time(). 
Something like:

static void
fill_time(PyObject *v, int index, time_t sec, unsigned long nsec)
{
    ...
    static PyObject *billion = NULL;

    if (billion == NULL) {
        billion = PyLong_FromLong(1000000000);
        if (!billion)
            return;
    }
    ...
}

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue14127>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to