Gregory P. Smith <g...@krypto.org> added the comment:

false alarm, thats just what happens when PYTHONHASHSEED=0 (I won't be 
committing the assert, I was just testing behavior).

For what its worth, the xmlparse.c generate_hash_seed() function is pretty poor 
as far as picking a random number goes as it is time based and it is often easy 
for an attacker to figure out the time on a process they're injecting data into 
and thus construct a targeted attack.  It is still better than nothing but it 
could be better.  I'd leave improving that up to the upstream expat project.

When PYTHONHASHSEED is enabled, pyexpat will never use that function. It does 
mean we use a constant seed for the life of the process when it is enabled, and 
revert to the expat behavior of using the expat parser creation time based seed 
otherwise.

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue14234>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to