Antoine Pitrou <pit...@free.fr> added the comment:

That looks like a good idea.
I don't understand the following code:

+        try:
+            self._dispatch_table = self.dispatch_table
+        except AttributeError:
+            self._dispatch_table = dispatch_table

... since self.dispatch_table is a property returning self._dispatch_table. Did 
you mean type(self).dispatch_table?

Also, you need to update the docs (which will also make the intended semantics 
of the patch clearer :-)).

----------
stage:  -> patch review

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue14166>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to