Nadeem Vawda <nadeem.va...@gmail.com> added the comment:

>> - test_glob_to_re() was doing two levels of escaping (r'\' -> r'\\\\')
>>   for its expected output when it should only do one (r'\' -> r'\\').
> Fix merged.  I don’t fully understand why one place needs two escapes and the 
> others just one.

I agree that this code is confusing, though. Perhaps we should add a
comment in glob_to_re():

    # Warning - manipulating a regex with a regex. Here be dragons.

;-)

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue6884>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to