Éric Araujo <mer...@netwok.org> added the comment: >I would say that this one is clear too: > aelf.assertTrue(isinstance(obj, cls)) > except that the failure message is not very friendly: > AssertionError: False is not true Yeah, you have to give something as third argument to ease debugging.
> If we keep assertIsInstance, more people will continue to misuse it just > because the > method exist, when they really want to check (type(obj) is cls). If they make that mistake, it is because they don’t understand what isinstance does. > An option could be to add a snippet to the documentation of > `assertIsInstance` stating > that the right way to check exact type is `assertIs(type(obj), cls)`. My point was that maybe they think they really want to check the type, but with Python you don’t have to care that much most of the time. +1 on a doc addition (I can even volunteer a patch) -0.5 on the proposed new argument ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue13387> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
