Antoine Pitrou <pit...@free.fr> added the comment: Here is my quick review: - shouldn't the opener also get the third open() argument (although it currently seems to always be 0o666)? - when fdobj is NULL, you shouldn't override the original error - PyLong_AsLong can fail (if the opener returns too large an int), you should check for that
Thank you! ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue12797> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
