Mark Hammond <skippy.hamm...@gmail.com> added the comment:
The first chunk of that patch is for when pythonhome==NULL. There is also a
similar block just under it when MS_WINDOWS is not defined. While I don't know
in which cases this will be built without that define, it looks as though the
*buf++ = DELIM; should also be added to that block?
Also, there is an existing conditional:
if (argv0_path) {
which can never be false (as argv0_path is a char array). It could be changed
to if (argv0_path[0]) but ISTM that it could also be removed completely - ie,
the 2 lines left in that block should have no effect in the case where the
buffer is empty.
I haven't actually tested it though, but apart from the first comment above, it
*looks* like it does the right thing :)
----------
nosy: +mhammond
_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue12989>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
