Antoine Pitrou <pit...@free.fr> added the comment: Thanks for the patch. This is a generally useful functionality and the patch looks mostly good. I have a couple comments:
- in _pwinfo_set(), you need to decref password_bytes when you're finished - you check the password size in _password_callback() but not in _pwinfo_set(), is it expected? is the size limit only meaningful with a callback rather than a predefined password? ---------- _______________________________________ Python tracker <rep...@bugs.python.org> <http://bugs.python.org/issue12803> _______________________________________ _______________________________________________ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com