Alexander Belopolsky <belopol...@users.sourceforge.net> added the comment:

The code review links point to something weird.  Victor, can you upload your 
patch for review?

My first impression is that your patch does not accomplish much beyond 
replacing some literal expressions with macros.  What I wanted to achieve with 
this issue was to enable writing code without #ifdef Py_UNICODE_WIDE branches.  
In your patch these branches seem to still be there and in fact it appears that 
new code is longer than the old one (I am not sure why, but I see more '+' than 
'-'s in your patch.)

----------

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue10542>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

Reply via email to