Antoine Pitrou <pit...@free.fr> added the comment:
Le mardi 19 juillet 2011 à 23:20 +0000, STINNER Victor a écrit :
> STINNER Victor <victor.stin...@haypocalc.com> added the comment:
>
> > Your patch looks fine to me, except for this:
> > - if (platform in ('linux2', 'freebsd4', 'freebsd5', 'freebsd6',
> > - 'freebsd7', 'freebsd8')
> > - or platform.startswith("gnukfreebsd")):
> > + if os.uname()[0] in ('Linux', 'FreeBSD'):
> >
> > Why not use platform.system(), to be consistent?
>
> I'm not sure that thp platform module can be used in setup.py
> (bootstrap issue?). It should be tested.
Why don't you just use platform.startswith? It would avoid introducing
bugs due to subtle differences between uname, platform or
platform.system.
----------
_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue12326>
_______________________________________
_______________________________________________
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
