[issue7484] smtplib: verify breaks with Postfix servers

[Felipe Cruz]

Felipe Cruz <felipec...@loogica.net> added the comment:

You're very kind David.

Hope I can contribute with something more relevant next time :)

best regards,
Felipe

2011/7/18 R. David Murray <rep...@bugs.python.org>

>
> R. David Murray <rdmur...@bitdance.com> added the comment:
>
> Thank you both for your work on this.  The patch I committed is a
> combination of my _addr_only, Filipe's tests, and Catalin's modifications to
> those tests.  quoteaddr, although in the __all__, is not documented and is
> really an implementation detail, as is the new _addr_only.  So I am only
> testing them indirectly through the documented parts of the API (I added a
> test for <> address, and one for an IDNA encoded address).
>
> Catalin, I think you are correct about the try/except/None stuff.  As far
> as I can tell it is left over from the old days before the email package and
> its philosophy of never throwing parsing errors.  Nowadays if parseaddr
> throws an error, it is a bug.  That's a refactoring not a bug fix, though,
> so I didn't backport it.
>
> ----------
> resolution:  -> fixed
> stage: test needed -> committed/rejected
> status: open -> closed
>
> _______________________________________
> Python tracker <rep...@bugs.python.org>
> <http://bugs.python.org/issue7484>
> _______________________________________
>

----------
Added file: http://bugs.python.org/file22693/unnamed

_______________________________________
Python tracker <rep...@bugs.python.org>
<http://bugs.python.org/issue7484>
_______________________________________
You&#39;re very kind David.<div><br></div><div>Hope I can contribute with 
something more relevant next time :)</div><div><br></div><div>best 
regards,</div><div>Felipe<br><br><div class="gmail_quote">2011/7/18 R. David 
Murray <span dir="ltr">&lt;<a 
href="mailto:rep...@bugs.python.org";>rep...@bugs.python.org</a>&gt;</span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc 
solid;padding-left:1ex;"><div class="im"><br>
R. David Murray &lt;<a 
href="mailto:rdmur...@bitdance.com";>rdmur...@bitdance.com</a>&gt; added the 
comment:<br>
<br>
</div>Thank you both for your work on this.  The patch I committed is a 
combination of my _addr_only, Filipe&#39;s tests, and Catalin&#39;s 
modifications to those tests.  quoteaddr, although in the __all__, is not 
documented and is really an implementation detail, as is the new _addr_only. 
 So I am only testing them indirectly through the documented parts of the API 
(I added a test for &lt;&gt; address, and one for an IDNA encoded address).<br>

<br>
Catalin, I think you are correct about the try/except/None stuff.  As far as I 
can tell it is left over from the old days before the email package and its 
philosophy of never throwing parsing errors.  Nowadays if parseaddr throws an 
error, it is a bug.  That&#39;s a refactoring not a bug fix, though, so I 
didn&#39;t backport it.<br>

<br>
----------<br>
resolution:  -&gt; fixed<br>
stage: test needed -&gt; committed/rejected<br>
status: open -&gt; closed<br>
<div><div></div><div class="h5"><br>
_______________________________________<br>
Python tracker &lt;<a 
href="mailto:rep...@bugs.python.org";>rep...@bugs.python.org</a>&gt;<br>
&lt;<a href="http://bugs.python.org/issue7484"; 
target="_blank">http://bugs.python.org/issue7484</a>&gt;<br>
_______________________________________<br>
</div></div></blockquote></div><br></div>

_______________________________________________
Python-bugs-list mailing list
Unsubscribe: 
http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com